I've only smacked DD a couple of times, always in immediate situations of danger (running on to the road is one that comes to mind).

However DD1 just always laughed at me when I did it! Not a very effective method for me!

We disciplined using time out in the hallway and we also had a fall back position to enforce the time out spot (which involved throwing away a toy). This pretty much always worked when we needed it to!