My DS was about 22 months when he started using a cup properly, and it pretty good with it now (almost 26 months), but rules are that the cup can't be full to the top and he has to sit down while drinking. If he's a bit too keen it will end up down his front.