Some of my earliest memories are sharing a room with my big brother. I think sharing a room is a great idea, especially for allowing them to bond - but I do think a top bunk might be a little unsafe for such a young child. Dachlostar's idea about the double bed bunk seems like a good way to start.

Good luck with it!