You've just got to do what works for you. My 2.5 year old DD still feeds to sleep every night. It is what I have always found easiest, and most nights she is asleep within the first 5-10 minutes. I did the same with my DS, and when he weaned he started falling asleep on his own really easily, and he is an awesome sleeper now.