I also used to feed Aidyn to sleep a lot for about the first 6-8 months of his life... I figured if it works at getting him all relaxed, then why not?
He has been fine since then, and certainly grown out of it - there is NO way he would fall asleep with a bottle/cup of milk these days!

And as for cuddling baby to sleep, I dont think that is spoiling them at all. I think it helps them feel secure and loved, and can't see anything wrong with it.
I know my mum and sister dont agree with my way of gentle parenting, as mum, and now my sister just put their babies in the cot and left them to cry themslves to sleep.
Well I just cant do that. It stresses me out and makes me feel panicky and ill when Aidyn is upset. So cuddling him to sleep etc is just as good for me, as it is for him.
Plus I like to think that we have a really close and loving relationship now because of it... he is a very affectionate and sweet little boy, and will come and cuddle and snuggle with me and DP heaps... and its just lovely.